WTAF? Is this written by a hallucinating AI?
I think it’s a joke (maybe)
I don’t think this is the sort of error an AI would make.
I’m a bit disappointed there isn’t a call to GetBooleanValue in there
“You aren’t writing enough lines of code!” - Management
My boss’s boss, a former Ops manager who liked to keep track of system stats, once asked her why the CPU usage on the dev box had decreased that month. Weren’t the devs doing any work?
I misread it as CompareBolians. No more Star Trek memes for me today.
Many Bolians died bringing us this information.
If this were a Node module, I wouldn’t even be surprised.
Straight from the famous book “Making LOCs for Dummies”
Don’t do OOP kids
That’s not OO code
Still good advice, though.
Not really. Good advice would be to use the right tool for the job
Not even once
Clearly it should be
return orig == val
Duh
To match the current behavior it should be orig != val
You’re hired. Can your start on Monday?
This is your brain when you OD on OOP.
There’s literally nothing related to OOP in this snippet.
You’re right, this is just not oop AT ALL.
For the correct OOP solution, you would need consider whether this can be thought of as a kind of stateless leaf method, and therefore implement it as an abstract (singleton) factory, but on the other hand, if you’re using a context object with the registry pattern, you should probably do this properly with IoC containers. If course, if your object graph isn’t too complex or entangled, you could always just do constructor injection but you risk manging your unit tests, so I would go cautiously if I were looking in that direction.
I love how OOP devolves into shoving code up it’s own ass.
I was just thinking it needed more factories
What about a factory for the factories! There’s nothing more efficient than a tool making tool making tool.
Shouldn’t there be a call to the boolean comparison microservices server in there somewhere? Also, we should consider the possibility that booleans and their operators could be overloaded to do something else entirely. We might need a server farm to handle all of the boolean comparison service requests.
SOLVED. On reflection, @[email protected] has come up with the perfect solution - let me explain,
Parallelism
YES. We should utilise a microservices architecture so that we can leverage a fundamental distributed interconnected parallelism to these boolean comparisons which is bound to beat naive single-thread, single-core calculation hands down. Already. But it gets better.
Load balancing
Of course a load balancing microservice would be useful because you don’t want one of the boolean comparison microservices accidentally taking too great a share of the computation, making the whole topology more brittle than it needs to be.
Heuristics
A boolean comparison request-comparing analytics microservice could evaluate different request distribution heuristics to the individual microservice nodes (for example targetting similar requests resolving to true/true or false/true etc versus fair-balancing-oriented server targetting versus pseudo-random distribution etc etc), and do so for randomly selected proportions of the uptime.
Analysis
The incoming boolean comparison requests would be tagged and logged for cross-reference and analysis, together with the computation times, the then-current request-distribution heuristic and the selected server, so that each heuristic can be analysed for effectiveness in different circumstances.
Non-generative AI
In fact, the simplest way of evaluating the different heuristic pragmas would be to input the aforementioned boolean comparison request logs, together with some general data on time of day/week/year and general performance metrics, into a neural network with a straightforward faster-is-better training programme, and pretty soon you’ll ORGANICALLY find the MOST EFFICIENT way of managing the boolean comparison requests.
Executive summary:
Organically evaluated stochastically-selected heuristics leverage AI for a monotonically-improving service metric, reducing costs and upscaling customer productivity on an ongoing basis without unnecessary unbillable human-led code improvement costs. Neural networks can be marketed under separate brands both as AI solutions and as LLM-free solutions, leveraging well-understood market segmentation techniques to drive revenues from disparate customer bases. Upgrade routes between the different marketing pathways can of course be monetised, but applying a 3%-above inflation mid-term customer inertia fee allows for prima-facia discounts when customers seek cost reduction-inspired pathway transfers, whilst ensuring underlying income increases that can be modelled as pervasive and overriding lower bounds for the two SAAS branches, independent of any customer churn, whilst well-placed marketing strategies can reasonably be expected to drive billable customer “upgrades” between pathways, mitigating any prima-facia discounts even before the underlying monotonicity price-structuring schemas.
You’re so right, I didn’t think of that. Maybe I’m not cut out to be a manager in IT.
Don’t forget the invocation
if (CompareBooleans(a, b) == true)
elseif(CompareBooleans(b,a) != false)
if (CompareBooleans(CompareBooleans(a, b), true))
I don’t like this thread anymore :(
No, no, this is actually the only correct code in the thread.
that… actually works…
“We need to obfuscate our code to prevent reverse engineering”
The obfuscation in question:
We affectionately called it “subscurity” on the FE team.
When our BE apis would not give us any information why something failed, nor would they give us access to their logs. Complete black box of undocumented doodoo, and they would proudly say “security through obscurity” every time we asked why they couldn’t make improvements to usability.
You must have been working with the Redditors who told me that avoiding the use of JavaScript’s
eval()
to parse JSON was a false sense of security.
Wait areBooleanEqual returns false when they are equal?
That’s not even the worst part. What the fuck does a function named Compare_anything do? Does it return anything? It sounds like nothing but a side effect.
The unnecessary and confusing functions are horrible, yes, but I’d still say that the fact that they’re wrong is the “worst” part.
That’s enough chit-chat, nerds. Back to work.
- Management
Usually comparison functions are supposed to return an integer and are usually useful for sorting. However this one returns a bool so it’s both useless and terribly named.
yesn’t
This actually made me laugh, thank you.
You can tell they’re amateurs. It’s not obfuscated enough. They won’t be able to keep their job.
They clearly need an abstract boolean comparison factory.
var CompareBooleans = new ComparatorFactory().BooleanComparator(new BooleanComparisonByEqualityPolicy()); if (CompareBooleans(a, b) == true) { System.Out.PrintLn("Sames!!!"); }
…
But now that I’ve written this, it’s C#, so it’s missing dependency injection.
I can imagine Uncle Bob be proud of this Clean Code ™
Thanks I hate it