A 15000 line PR landing on a Friday evening for the lucky random reviewer to open on Monday. “Please approve it fast so we avoid too many conflicts.”
Yeah, this is my colleagues waiting for me, poor bastards
The worst case is when someone requires changes, you address them, but then they disappear/go on a leave.
If the repository rules require all conversations to be resolved before merging and only the original reviewer can mark them as solved, the PR is stuck forever even if the rest of the team approves it.
That sounds like something you bring up in the retro
When the person came back from the leave I made some passive aggressive remark, hope this is enough 🤣
Have you tried ignoring their PRs for a few weeks?
This always happens to me when I’ve written some genius code. Takes so long to review it, because my caveman colleagues don’t understand it.
Also me waiting for the junior dev to address review comments satisfactorily.
It’s a game where they try to make you impatient enough that you do it for them.
